fix: use retraction_reason in file view alert #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
crfmc
commented
Apr 28, 2025
•
crfmc
commented
- Use retraction_reason property to create file overview alert string instead of notes_to_tsv
- fix: remove from accessionsOfInterest array - feat: add retraction reason to string
There was a problem hiding this comment.
Pull Request Overview
This PR updates the file view alert to use the retraction_reason property instead of notes_to_tsv and refines the alert rendering conditions. Key changes include:
- Using retraction_reason to construct the retracted warning message.
- Adjusting the accessionsOfInterest list to only include one accession.
- Bumping the project version in pyproject.toml.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/encoded/static/components/item-pages/FileView.js | Updated alert logic to use retraction_reason and modified conditions. |
| pyproject.toml | Incremented version from 0.165.0 to 0.165.1 to reflect the changes. |
Files not reviewed (1)
- CHANGELOG.rst: Language not supported
Comments suppressed due to low confidence (2)
src/encoded/static/components/item-pages/FileView.js:104
- Remove or disable the console.log used for debugging to avoid unintended log output in production.
console.log('context', context);
src/encoded/static/components/item-pages/FileView.js:102
- Review the removal of 'SMAFI557D2E7' from the accessionsOfInterest list to ensure the alert behavior remains as intended.
const accessionsOfInterest = ['SMAFIB6EQLZM'];
utku-ozturk
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.